Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metric/Instrument tags and scopes #5140

Open
wiktork opened this issue Aug 14, 2023 · 0 comments
Open

Add support for Metric/Instrument tags and scopes #5140

wiktork opened this issue Aug 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@wiktork
Copy link
Member

wiktork commented Aug 14, 2023

For dotnet 8, meters now support additional information as part of the meter itself (rather than each individual value). See https://github.com/dotnet/runtime/pull/90417/files#diff-8797eae6d3e644ed047f952e10d4240fe18175f754586666823b555f46968672L1435-R1486.

This includes:

  • Description
  • Scope hash (may not be necessary initially since there are not many scenarios that use this)
  • Tags (note this tag is not for the payload values but for the meters themselves).

The data can be gathered as part of the BeginInstrumentReporting TraceEvent. See https://github.com/dotnet/diagnostics/blob/9eee79a44914fdb703664ee6461298161339cb4f/src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs#L82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant