Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading name of container_memory_failures_total metric #3535

Open
AlexZzz opened this issue Jun 5, 2024 · 0 comments
Open

Misleading name of container_memory_failures_total metric #3535

AlexZzz opened this issue Jun 5, 2024 · 0 comments

Comments

@AlexZzz
Copy link

AlexZzz commented Jun 5, 2024

Hi!
Metric container_memory_failures_total has a misleading name and description: Cumulative count of memory allocation failures . Page faults are not failures actually. Reading the name of this metric makes me think about SIGSEGV or OOM, but not about page faults.

It also unclear for people who are not familiar with memory management.

It would be better to name it: container_memory_page_faults_total and make label type: minor|major

I understand that this is a breaking change:) creating this issue as a suggestion and for feature searchers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant