Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move int64_t casting to bgv-to-openfhe #647

Open
j2kun opened this issue Apr 24, 2024 · 1 comment
Open

move int64_t casting to bgv-to-openfhe #647

j2kun opened this issue Apr 24, 2024 · 1 comment
Labels
dialect: openfhe Issues related to the openfhe dialect good first issue Good for newcomers

Comments

@j2kun
Copy link
Collaborator

j2kun commented Apr 24, 2024

I originally wrote the bgv-to-openfhe lowering without a complete understanding of the limitations of the OpenFHE API, which results in a decent amount of cruft related to casting types during OpenFHE codegen. For example, the input to an encode op in OpenFHE must be int64_t, but the codegen supports inputs of type int16_t and casts them in C++ generated code.

This is relatively small, but since this is part of the OpenFHE API, it would be more coherent to represent those constraints as openfhe op type constraints, and insert casting ops in the lowering from BGV to OpenFHE, and then have simpler codegen for the cast ops directly.

@j2kun j2kun added the dialect: openfhe Issues related to the openfhe dialect label Apr 24, 2024
Copy link

github-actions bot commented Apr 25, 2024

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

@j2kun j2kun added the good first issue Good for newcomers label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: openfhe Issues related to the openfhe dialect good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant