-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The icons of ConfigDialog
and DictionaryTools
looks jaggy on macOS.
#964
Comments
If there are no problem, I'll prepare a PR for replacing the icons. |
Hi lazylynx, Thank you for your report. Yes, please feel free to send a PR. Could you please add a note about how to reproduce your PR to the commit log? (i.e. how to create the same product_icon.icns for other people) Best regards, |
Yes, off course! |
If the PNG images can be programmatically created from the SVG file, a comment is totally fine. Thank you, |
Since I've retouched images with Figma, I add all PNG images to the PR. Thank you. |
Description
The icons of
ConfigDialog
andDictionaryTools
looks jaggy on macOS.Steps to reproduce
Steps to reproduce the behavior:
ConfigDialog
andDictionaryTool
s' icons.Screenshots
Version or commit-id
Mozc-2.30.5490.101+24.11.oss
But it seems that this behavior continues from older Mozc.
Environment
Investigations
This behavior is due to the fact that
src/data/images/mac/product_icon.icns
does not have sufficient resolution images.Currently, the file seems to only include a 32x32 pixels image.
Once product_icon.icns contains larger images, this issue will be resolved.
Here is a screenshot showing Mozc built from my working branch with higher resolution images in product_icon.icns( https://github.com/lazylynx/mozc/actions/runs/9681442036 ). They are created from
src/data/images/icon.svg
with margins modified.Additional context
icns specification is here:
https://en.wikipedia.org/wiki/Apple_Icon_Image_format
https://web.archive.org/web/20180618155438/https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/
The text was updated successfully, but these errors were encountered: