Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icons of ConfigDialog and DictionaryTools looks jaggy on macOS. #964

Open
lazylynx opened this issue Jul 1, 2024 · 5 comments
Open

Comments

@lazylynx
Copy link

lazylynx commented Jul 1, 2024

Description

The icons of ConfigDialog and DictionaryTools looks jaggy on macOS.

Steps to reproduce

Steps to reproduce the behavior:

  1. Build and install Mozc for macOS.
  2. Open launchpad and confirm ConfigDialog and DictionaryTool s' icons.

Screenshots

jaggy

Version or commit-id

Mozc-2.30.5490.101+24.11.oss
But it seems that this behavior continues from older Mozc.

Environment

  • OS: macOS Sonoma 14.5

Investigations

This behavior is due to the fact that src/data/images/mac/product_icon.icns does not have sufficient resolution images.
Currently, the file seems to only include a 32x32 pixels image.
Once product_icon.icns contains larger images, this issue will be resolved.

Here is a screenshot showing Mozc built from my working branch with higher resolution images in product_icon.icns( https://github.com/lazylynx/mozc/actions/runs/9681442036 ). They are created from src/data/images/icon.svg with margins modified.

smooth

Additional context

icns specification is here:
https://en.wikipedia.org/wiki/Apple_Icon_Image_format
https://web.archive.org/web/20180618155438/https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/

@lazylynx
Copy link
Author

lazylynx commented Jul 1, 2024

If there are no problem, I'll prepare a PR for replacing the icons.

@hiroyuki-komatsu
Copy link
Collaborator

Hi lazylynx,

Thank you for your report. Yes, please feel free to send a PR.

Could you please add a note about how to reproduce your PR to the commit log? (i.e. how to create the same product_icon.icns for other people)

Best regards,

@lazylynx
Copy link
Author

lazylynx commented Jul 3, 2024

Could you please add a note about how to reproduce your PR to the commit log? (i.e. how to create the same product_icon.icns for other people)

Yes, off course!
Is it better to include not just the product_icon.icns file, but also the PNG images used to create the .icns file in the PR?
As shown here, icns files are generated from PNG images with specific sizes and names.

@hiroyuki-komatsu
Copy link
Collaborator

If the PNG images can be programmatically created from the SVG file, a comment is totally fine.
If you needed to retouch the PNG images by hands, I'd like have the PNG images too.

Thank you,

@lazylynx
Copy link
Author

lazylynx commented Jul 4, 2024

Since I've retouched images with Figma, I add all PNG images to the PR.
I'd appreciate if you check the PR.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants