Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for WebM compatibility #27

Open
bvibber opened this issue Jan 18, 2018 · 5 comments
Open

Update for WebM compatibility #27

bvibber opened this issue Jan 18, 2018 · 5 comments

Comments

@bvibber
Copy link
Collaborator

bvibber commented Jan 18, 2018

ogv.js 1.5 includes WebM support enabled by default; should update the source checks so WebM audio and video sources get through.

@rigelk
Copy link
Contributor

rigelk commented May 31, 2018

@Brion I've done an update of the dependencies in #28 - do you think WebM support only needs updating the ogv dependency as I've done or needs more refactoring?

@bvibber
Copy link
Collaborator Author

bvibber commented Jun 4, 2018

@rigelk I think it needs one more tweak which I temporarily patched out over in MediaWiki land here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/TimedMediaHandler/+/master/patches/videojs-ogvjs-webm.patch

That changes the canPlayType method to pass through to the underlying player.

@rigelk
Copy link
Contributor

rigelk commented Jun 4, 2018

Ah thanks!

I get the error that _OGVPlayer2 is not defined when doing the changes of your patch in src/plugin.js. Any idea what I could be missing?

@bvibber
Copy link
Collaborator Author

bvibber commented Jun 4, 2018 via email

@rigelk
Copy link
Contributor

rigelk commented Jun 4, 2018

Ah I wasn't sure if it was due to the scoping, thanks!

Seems to do the trick ; it's now in the PR: https://github.com/hartman/videojs-ogvjs/pull/28/files#diff-a4f485aa834ca5b3c24819fceb39c56fR556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants