Feature Request: A workflow should still be triggered by adding a label to a PR even if the head commit has [no ci]
#116939
Unanswered
larmitage-bjss
asked this question in
Actions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
I believe this is not a bug and was intentional but I don't think it makes a lot of sense, I would not expect it to work the way it currently does.
If this is my workflow trigger:
And I have the latest commit
[no ci] made some change
And I manually add a label to the pull request
Expected behaviour
I expect the workflow to run as the latest commit on the branch is irrelevent in this scenario. The event triggering the workflow is the label being added or removed, NOT the commit being pushed.
This should also be the same on all other pull request events that aren't triggered by a commit i.e. for pull_request I think this is every type apart from
synchronise
If the label was added by a workflow using the default github token, then I wouldn't expect the workflow to run
Actual behaviour
The workflow does not run until I make another (empty or otherwise) commit which does not contain
[no ci]
(and then add/remove the label)An example of where this is a problem:
.github/workflows
which cannot be done with the default token) - and so the commit message adds[no ci]
to the commit message to ensure no further workflows are triggered by pushing the commit[no ci]
. If the developer then adds the label, the check to ensure the PR is labeled correctly does not run and the PR cannot be merged.Beta Was this translation helpful? Give feedback.
All reactions