Open commit suggestions are put into "hidden conversations" while resolved are presented

[matkoniecz]

Open streetcomplete/StreetComplete#3648

Note

Note log list of recent resolved commit suggestions.

Use "Load more..."

Note that some hidden commit suggestions are open.

Commit suggestions not marked as resolved should be shown in preference to ones marked as resolved, even if older.

[danfishgold]

this is a really annoying problem. my team members have already missed several review comments because they were hidden

even when I send them a link to a specific comment that they missed (something like org/repo/pull/123#discussion_r12345678), the link doesn't auto-expand hidden comments so I can't really work around this problem

[davidmigloz]

I see this happening again and again, colleagues missing unresolved conversations in PRs because they are hidden.
If a conversation is unresolved, what's the purpose of hidden it?

[matkoniecz]

streetcomplete/StreetComplete#4642 - some quite large PR with many reviews, GitHub again gets confused (117 comments, 250 commits proposed to be added)

even linking to specific discussion like streetcomplete/StreetComplete#4642 (comment) streetcomplete/StreetComplete#4642 (comment) streetcomplete/StreetComplete#4642 (comment) streetcomplete/StreetComplete#4642 (comment) sometimes fails (no pattern found so far)

It seems that seemingly "Outdated" are especially prone to disappearing even when discussion itself is relevant (and that is why it was NOT marked as resolved!)

But not only them! As bonus, wait time for showing hidden comments is several seconds after you request unrolling comments...

[odahcam]

I think comments should always be shown next to the lines they were made even if new commits are added. There could be a reference old line or something but the comments should always show unless resolved, otherwise there's no value in commenting a PR if my comment is gonna vanish after a new commit is added, I'll have to review everything anyways.