Feedback: Comments on individual commits (made outside a pull request) no longer appear in the pull request timeline

[willsmythe]

We recently rolled out a change (changelog) to no longer show comments added to individual commits (comments added outside the context of a pull request) on the pull request timeline. Previously, if a pull request happened to include a commit that had commit comments, those comments would appear on that pull request's timeline. Users often reported that these comments were irrelevant to the pull request or caused confusion when added by someone not involved in the review.

What changed

Prior to this change, comments on individual commits (made outside the context of the pull request) would appear in the timeline of any pull request that included that commit:

With this change, commit comments (like the highlighted 029541b comment) no longer appear in the pull request timeline.

The timeline events REST and GraphQL APIs also no longer return commit comments associated with any commits included in the pull request.

What did not change

This change did not impact a user's ability to add, view, or manage comments on individual commits.

• Users can still add comments to individual commits or changed lines in a commit
• Users can still review pull requests one commit at a time and add review comments
• Commit comments still surface on the commits listing page
• Commit comments still surface at the bottom of the commit page
• Commit comments are still accessible from the Commits tab of the pull request page
• Commits pushed to a pull request head branch still surface in the timeline and on the Commits tab of the pull request page

There was also no impact to commit messages, i.e. the message stored with the Git commit. Commit messages continue to surface everywhere they previously surfaced, including on the pull request page.

Let us know what you like or don't like about this change.

[tobiasviehweger]

I've got a question regarding this, because I'm not sure if this is the same thing. Yesterday, I started with the review of a pull request, but did not completely finish with all the files. To allow the PR opener to work on the partial comments, I submitted the review with "Comment". Today, when using the "Files changed" tab, to continue working on the PR, my comments from yesterday are not shown inline anymore, but only on the main commit UI - is this a side effect of that change?

[willsmythe]

This is unrelated to the announced change.

If you navigate to the Conversation tab of the pull request, do you see your comments marked as "outdated"? This can happen if changes were pushed to the file after you commented. If this is the case and you click the link on the comment, you should get taken to the Files Changed (or Commits) tab filtered to a specific commit and should see your comment again.

If that doesn't work, I would contact GitHub Support since they'll have access to more details and can help figure out what's going on!

[donatj]

So we attach human readable diffs to commits with lock file changes as they can be quite impenetrable otherwise.

here is a simple example

These diffs no longer show on Pull Requests, and that's a problem for us.

[frank-segui]

Hey there, we have a case were we build a preview site and post the url in the workflow to the commit. Then users were able to see the comment on the pr and know where to go. With this change that comment is no longer obvious. The workflow can run before the PR is created so adding it to the pr is not that feasible. Is there a way to handle this case after the change?

[devinrhode2]

Hmm... So if someone comments on a certain line of a commit, and then PR author force pushes new commits (trying to keep clean history)... those comments are basically lost. The notifications feed on github.com might not even show what's going on there either, there can be other comments at the bottom of the actual Pull Request page, and, I guess they would have no idea there's also some comments on a commit that are basically lost now.

I guess, something to check on: Do comments on commits create a new "<li>" on the /notifications page? I suppose the notifications page could get too messy that way. If you frequently force push new commit history, each unique sha basically makes an appearance on the /notifications page... there could be a lot of "commit comment threads" that "clutter"(?) up the /notifications page.

[gre]

we have CI automation that is running on commits and gives a nice report by commenting on the commit. The fact we no longer see the report also on the PR is a regression to us and we would love to have the ability to have it back, maybe as a settings?

[pefribeiro]

Very odd for this functionality to just suddenly disappear. I had to Google for this change as it all went under the radar.

[deitry]

Is there a single place to see all the commit comments in the repo? It feels more and more difficult to get into conversation if someone makes a comment on a commit that you was not involved with and was not directly mentioned.

I think it's a big omission that there is no separate "commit comments" category in repo's Discussions page.

[eroller]

It would be nice if, when commenting on a commit, we could have the option to add the comment to the associated PR rather than to the commit (or maybe both?). I don't know how this would interact with force pushes on the PR, but it is definitely nice seeing the comments and diffs within the PR directly and being able to make sure each one is resolved before approving the PR.

[revolter]

So, is it true that there is no way to review a PR by asking the OP to change something with an entire commit?

[deitry]

There is an option to "request changes"

[revolter]

Both this discussion and my comment refer to comments on commits.

[deitry]

Yes they are, but you said "there is no way .." when there is actually another way - and it works better (well, in terms of GitHub UI) when you want to point out that changes should be made.

[revolter]

You didn't understand me. It looks like you can link a review comment to a line of code, but not to an entire commit.