Set Pull Request merge_commit_sha from API #43809
Unanswered
TheShermanTanker
asked this question in
API and Webhooks
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
Hi,
I'm one of the Committers for the OpenJDK project that maintains the official JDK. Our whole integration process for Pull Requests is currently controlled by an automated tool named Skara, which handles Pull Requests and pushes them as commits to our repositories, keeping the review process streamlined and efficient.
However, as an unfortunate side effect of this, the tool also has no choice but to close all integrated Pull Requests. This makes all of our Pull Requests look like they were rejected, which can alarm new contributors who may have missed the integrated label, and also doesn't blend with the GitHub workflow very well (We would like an integrated Pull Request to be able to trigger things like the Pull Shark achievements for example).
This has been a pain point for us for quite a while, and we would like Skara to be able to mark Pull Requests as merged even if we don't merge them directly via the merge endpoint. Would it be possible to enhance the API to have the ability to set the PR status to merged (complete with the purple merge icon to make it friendly for new contributors)? Or, even better, also have the ability to set the SHA of the commit it was merged by? (The reason we'd like to be able to do the latter is because we would like the Pull Request that was marked as merged to be listed under the commit title when one clicks on the corresponding commit, as is already done when it's merged normally):
best regards,
Julian Waters
Committer @ the OpenJDK Group
Beta Was this translation helpful? Give feedback.
All reactions