Run github actions before merge

[jacobwojcik]

Select Topic Area

Question

Body

Hi, I want to run an expensive job only before merge to main branch, so if the job fails the merge is canceled.
I know about

on:
  push:
    branches:
      - master

But it runs after merge and I want protect the main branch.

[multikitty]

Hi, @jacobwojcik

on:
  pull_request:
    branches:
      - master

try pull_request instead of push
hope this will help you.

[jacobwojcik]

Does it run after every push in pr branch? Because I want prevent it

[multikitty]

github action runs when a pull request is opened on the main branch. specifically, triggered when the pull_request event occurs on the main branch, and the workflow's on parameter filters the events to only run in that scenario.
this means , the workflow will run whenever a pull request is opened on the main branch, and it will not run on every push to the pull request branch.
howevr, you can modify the on parameter to specify different trigger events, such as pull_request_target or push , depending on your specific requirements.
by doing so, you can customize the workflow to run based on specific changes to the pull request branch.

Please have a try and check.

[HalDavis2]

is there a .net varify website in MSBuild

[jsoref]

Try merge queues:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions

[air3ijai]

Not sure if Merge queue are flexible enough or maybe I miss something.

1. We need to set a set of jobs names which should report their status
2. Jobs names for PR should be equal to Job names for Merge queue
3. Or we should run PR jobs and Merge queue jobs at both events - merge_group and pull_request which is unacceptable

In case we have a different set of jobs and their names, especially in matrix, a single way to do that is to use same matrix which is unacceptable (p.3 above).

@jacobwojcik, how did you solve that for your case?

[jsoref]

Can you explain why 3 is a problem?

Certainly while you're reviewing a PR, you need to know if the contents of the PR are valid.

Once you've established that the contents of the PR are independently valid, surely you'll want to know if the contents of the PR are still valid with any new things that are being included after the PR was tested but before it actually merges.

[air3ijai]

It is the same as in the initial message

I want to run an expensive job only before merge to main branch, so if the job fails the merge is canceled.

We want to run some additional checks only before the merge and not at the PR creation or every next commits to it.

[air3ijai]

So, a simple solution which will check the status based on the job name PR check, will work with the example above.

But it is very ambiguous and limited solution with the same job name in a different workflows. Merge queue jobs names should be a separate option with own setting.

pr.yaml

name: PR

on:
  pull_request:

jobs:
  pr:
    name: PR check
    runs-on: ubuntu-latest
    steps:
      - name: PR check
        run: |
          echo sleep 10

mq.yaml

name: MQ

on:
  merge_group:

jobs:
  mq:
    name: PR check
    runs-on: ubuntu-latest
    steps:
      - name: Merge queue check
        run: sleep 120

We are not alone and people actively discuss similar issues - merge queue.

And main thread - Pull Request Merge Queue Public Beta Feedback #46757.

[setoelkahfi]

Select Topic Area

Question

Body

Hi, I want to run an expensive job only before merge to main branch, so if the job fails the merge is canceled.

I know about

on:

  push:

    branches:

      - master

But it runs after merge and I want protect the main branch.

Did you find the solution? We have the same problem, as in our development branch has release build configuration than the PR branch. I want to run a last check after two approvals in a PR to prevent running the release configuration on every PR created.

[air3ijai]

We have discussed two possible workarounds for merge queue - Merge queue specific checks #103114.

Maybe it may fits your needs.

[setoelkahfi]

Thanks! I'll take a look