"X left review comments" link into the void once the PR gets updated / force pushed #58728
Unanswered
xmo-odoo
asked this question in
Pull Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Bug
Body
Part of a long series of "github really doesn't handle PR force pushes well", the quick links to review comments in the sidebar of PRs apparently link to the comments within the context of the commit they were left on, within the context of the PR.
If the branch has since been rebased, these links just lead to a "We went looking everywhere, but couldn’t find those commits." page with no content, as the commit is not part of the PR anymore. That is despite the reviews (and their comments) being shown down the Conversation page even if the commit they were attached to has since been removed.
Beta Was this translation helpful? Give feedback.
All reactions