Fix to support Storybook UI and React #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional fixes to support all major React platforms (SB, CRA, Next JS, etc.)
feat: Storybook fix
Issuewithflags
|
Hi @erie149, Thank you a lot for contributing to Flagpack! I've checked your PR and it looks like it's having some issues regarding importing React. It looks like React shouldn't be a peerDependency. When changing react to a regular dependency I'm also facing a bug where the SVG isn't loaded properly. I'm not completely sure why.
Are you able to reproduce this error? Please let me know. |
UltronOne
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.