A switch to set dpi for images w/o dpi information. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrito
reviewed
Jul 7, 2020
| strcmp(argv[i], "--dpi") == 0) { | ||
| char *endptr; | ||
| long t_dpi = strtol(argv[i+1], &endptr, 10); | ||
| if (*endptr) { |
There was a problem hiding this comment.
It looks like the indentation of this section got screwed up, but the patch looks nice (not yet tested), since it would avoid having waste time (and space) to convert bazillion pages to an intermediary format just to set the DPIs (and let leptonica decode all the images that were coded into the intermediate format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been creating pdf's from portable bitmaps, but I couldn't set resolution. I've added a switch to set resolution, currently it sets dpi if original image has no dpi information.