Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/test-templates #41843

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 28, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/test-templates

  • Subscription: df18da90-7007-4624-9744-08dc65780c30
  • Build: 20240703.1
  • Date Produced: July 3, 2024 9:55:18 AM UTC
  • Commit: 381a52eabdfba03775f9f5887130803d7079d1aa
  • Branch: refs/heads/main

…ld 20240628.1

Microsoft.SourceBuild.Intermediate.test-templates , Microsoft.DotNet.Test.ProjectTemplates.9.0
 From Version 1.1.0-rc.24327.2 -> To Version 1.1.0-rc.24328.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jun 28, 2024
@akoeplinger
Copy link
Member

@mthalman @Evangelink this seems to cause a conflict with the scenario-tests since they already have a global.json file:

    [FAIL] Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMSTestTemplate(language: CSharp)
    System.InvalidOperationException : Failed to execute D:\a\_work\1\vmr\artifacts\obj\extracted-dotnet-sdk\dotnet.exe new mstest --name SdkTemplateTests_MSTest_CSharp --output D:\a\_work\1\vmr\artifacts\scenario-tests\artifacts/SdkTemplateTests_MSTest_CSharp --language "C#"
    Exit code: 73
    
    Creating this template will make changes to existing files:
      Overwrite   global.json
    
    To create the template anyway, run the command with '--force' option:
       dotnet new mstest --name SdkTemplateTests_MSTest_CSharp --output D:\a\_work\1\vmr\artifacts\scenario-tests\artifacts/SdkTemplateTests_MSTest_CSharp --language C# --force
    
    For details on the exit code, refer to https://aka.ms/templating-exit-codes#73
       at Microsoft.DotNet.ScenarioTests.Common.ExecuteHelper.ValidateExitCode(ValueTuple`3 result, Int32 expectedExitCode) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.Common/ExecuteHelper.cs:line 106
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteCmd(String args, String workingDirectory, Action`1 additionalProcessConfigCallback, Int32 expectedExitCode, Int32 millisecondTimeout) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 37
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteNew(String projectType, String projectName, String projectDirectory, String language, String customArgs) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 103
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTest.Execute(DotNetSdkHelper dotNetHelper, String testRoot, String[] frameworks, String PreMadeSolution) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTest.cs:line 36
       at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMSTestTemplate(DotNetLanguage language) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs:line 84
       at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
       at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

@Evangelink
Copy link
Member

Hi @akoeplinger,

Thanks! I need to check how I could add my entry to existing global.json then.

…ld 20240702.1

Microsoft.SourceBuild.Intermediate.test-templates , Microsoft.DotNet.Test.ProjectTemplates.9.0
 From Version 1.1.0-rc.24327.2 -> To Version 1.1.0-rc.24352.1
@Evangelink
Copy link
Member

I have reverted the change while waiting for me to fix something on templating SDK side that I could integrate on my template.

…ld 20240702.1

Microsoft.SourceBuild.Intermediate.test-templates , Microsoft.DotNet.Test.ProjectTemplates.9.0
 From Version 1.1.0-rc.24327.2 -> To Version 1.1.0-rc.24352.1
…ld 20240703.1

Microsoft.SourceBuild.Intermediate.test-templates , Microsoft.DotNet.Test.ProjectTemplates.9.0
 From Version 1.1.0-rc.24327.2 -> To Version 1.1.0-rc.24353.1
@dotnet-maestro dotnet-maestro bot merged commit e09e3a5 into main Jul 3, 2024
41 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-a33617f0-9826-4e22-8f20-a06608c8b992 branch July 3, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants