Correct the VNC password attribute #139
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the refactor to the XML builder a subtle bug was introduced which caused the password not to be set. This uses the correct attribute. Fixes: 6db6f80 ("Replace server XML with Nokogiri::XML::Builder")
|
Patch has been tested successfully on fog-libvirt (from package rubygem-fog-libvirt-0.12.0-1.el8.noarch) |
|
I see the failure also happens in master, so I wonder what changed. |
|
Looks like https://gitlab.com/libvirt/libvirt-ruby/-/commit/27907495e7ecf8122b0ea3e66e3fa34d2714b5a8 introduced this regression. |
|
I started the fixes in #140. |
|
Confirmed working on a v3.9.1 katello installation 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the refactor to the XML builder a subtle bug was introduced which caused the password not to be set. This uses the correct attribute.
Came up in https://community.theforeman.org/t/error-creating-libvirt-based-guest-after-upgrading-to-3-10/38295. I'm asking the reporter to test this patch.
Fixes: 6db6f80 ("Replace server XML with Nokogiri::XML::Builder")