storage: add openstack_storage_url option #454
Conversation
lib/fog/openstack/core.rb
Outdated
| @@ -237,6 +230,19 @@ def authenticate | |||
|
|
|||
| true | |||
| end | |||
|
|
|||
| protected | |||
There was a problem hiding this comment.
Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after protected.
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
lib/fog/openstack/core.rb
Outdated
| @@ -237,6 +230,20 @@ def authenticate | |||
|
|
|||
| true | |||
| end | |||
|
|
|||
| protected | |||
There was a problem hiding this comment.
Unless I missed something I believe private should be enough.
|
This looks good. Just a question, see above conversation. |
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
elthariel
force-pushed
the
support_swift_storage_url
branch
from
ae76c75
to
48924b0
Compare
|
Build succeeded.
|
|
@ShamoX seems reasonable to me and should be backwards compatible, thoughts? |
|
Yes, seems good, but adding a test like @gildub proposed would improve confidence. @elthariel still need help here to do it (even after @gildub proposition) ? |
In order to support ACL management in my provider (OVH), I need to have users in a different tenant and I need to use another base URL for my storage calls. In the python client it is implemented using the OS_STORAGE_URL.
This is the equivalent option for fog.
I don't really know how to add tests to this, suggestions are highly welcomed
Signed-off-by: Julien 'Lta' BALLET [email protected]